feat(companions-pane): Add new companions pane to saved trip editor and account settings screen #1289
+540
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
requested changes
Oct 18, 2024
| @@ -48,6 +49,13 @@ const ExistingAccountDisplay = (props: Props) => { | |||
| <FormattedMessage id="components.MobilityProfile.MobilityPane.header" /> | |||
| ) | |||
| }, | |||
| { | |||
| collapsible: true, | |||
There was a problem hiding this comment.
It is an interesting feature that was in the mockup, although I'm split on whether to have it for this pane. I'll let the other reviewer weigh in.
There was a problem hiding this comment.
I'm not the biggest fan of it here. I think this is a nice to have feature, but it doesn't make sense if this is the only section that uses it. If all the sections were collapsable I think this would make more sense.
josh-willis-arcadis
force-pushed
the
trusted-companions
branch
2 times, most recently
from
27da499 to
600fd50
Compare
binh-dam-ibigroup
approved these changes
Nov 7, 2024
miles-grant-ibigroup
requested changes
Nov 13, 2024
|
The |
3 tasks
miles-grant-ibigroup
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add ui for trusted companion to the saved trip editor and account settings screens.
Sketch can be found here: https://www.sketch.com/s/3e1c091e-4fb3-4e51-8f17-86be7a8c7b1b
PR Checklist: